From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: make xattr extension work with new local alloc reservation.
Date: Thu, 8 Jul 2010 11:36:23 -0700 [thread overview]
Message-ID: <20100708183623.GC17445@mail.oracle.com> (raw)
In-Reply-To: <1276830171-5908-1-git-send-email-tao.ma@oracle.com>
On Fri, Jun 18, 2010 at 11:02:50AM +0800, Tao Ma wrote:
> + goto restarted_transaction;
There's no need to confuse the issue with gotos here. Just make
it a loop, while (clusters_to_add). Make the vb->vb_access through
ocfs2_journal_dirty() parts a subfunction so that the loop is readable.
Have the subfunction return the number of clusters added, or -errno on
error. Then process the why in this function.
Joel
--
"Reader, suppose you were and idiot. And suppose you were a member of
Congress. But I repeat myself."
- Mark Twain
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-07-08 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 3:00 [Ocfs2-devel] [PATCH 0/2] ocfs2: make xattr work with new local alloc reservation Tao Ma
2010-06-18 3:02 ` [Ocfs2-devel] [PATCH] ocfs2: make xattr extension " Tao Ma
2010-07-08 18:36 ` Joel Becker [this message]
2010-07-08 18:51 ` Joel Becker
2010-07-09 3:38 ` Tao Ma
2010-07-09 8:01 ` Joel Becker
2010-06-18 3:02 ` [Ocfs2-devel] [PATCH] ocfs2: Make xattr reflink " Tao Ma
2010-06-18 3:29 ` [Ocfs2-devel] [PATCH v2] " Tao Ma
2010-07-08 19:42 ` [Ocfs2-devel] [PATCH] " Joel Becker
2010-07-09 4:03 ` Tao Ma
2010-07-08 18:27 ` [Ocfs2-devel] [PATCH 0/2] ocfs2: make xattr " Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708183623.GC17445@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).