ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	ocfs2-devel@oss.oracle.com
Cc: John Stultz <johnstul@us.ibm.com>,
	Keith Maanthey <kmannth@us.ibm.com>,
	Eric Whitney <eric.whitney@hp.com>
Subject: [Ocfs2-devel] [PATCH, RFC 2/3] jbd2: Change j_state_lock to be a rwlock_t
Date: Tue, 3 Aug 2010 20:08:39 -0400	[thread overview]
Message-ID: <20100804000839.GI9453@thunk.org> (raw)
In-Reply-To: <1280851315-9167-3-git-send-email-tytso@mit.edu>

On Tue, Aug 03, 2010 at 12:01:54PM -0400, Theodore Ts'o wrote:
> Lockstat reports have shown that j_state_lock is a major source of
> lock contention, especially on systems with more than 4 CPU cores.  So
> change it to be a read/write spinlock.
> 
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

Oops, this patch can result in a BUG_ON in fs/jbd2/transaction.c.  I'm
currently testing a fix/replacement patch, but I figured I send a
quick warning to folks not to waste time trying this out just yet.  I
should hopefully have a new, better-tested patch in by tomorrow
morning.

						- Ted

  reply	other threads:[~2010-08-04  0:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 16:01 [Ocfs2-devel] [PATCH, RFC 0/3] *** SUBJECT HERE *** Theodore Ts'o
2010-08-03 16:01 ` [Ocfs2-devel] [PATCH, RFC 1/3] jbd2: Use atomic variables to avoid taking t_handle_lock in jbd2_journal_stop Theodore Ts'o
2010-08-03 16:01 ` [Ocfs2-devel] [PATCH, RFC 2/3] jbd2: Change j_state_lock to be a rwlock_t Theodore Ts'o
2010-08-04  0:08   ` Ted Ts'o [this message]
2010-08-03 16:01 ` [Ocfs2-devel] [PATCH, RFC 3/3] jbd2: Remove t_handle_lock from start_this_handle() Theodore Ts'o
2010-08-03 19:07 ` [Ocfs2-devel] [PATCH, RFC 0/3] *** SUBJECT HERE *** Joel Becker
2010-08-03 20:07   ` Ted Ts'o
2010-08-03 21:19     ` Joel Becker
2010-08-03 22:57       ` Ted Ts'o
2010-08-10  3:40 ` [Ocfs2-devel] [PATCH, RFC 0/3] *** SUBJECT HERE *** (ext4 scalability patches) Eric Whitney
2010-08-11 21:08   ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100804000839.GI9453@thunk.org \
    --to=tytso@mit.edu \
    --cc=eric.whitney@hp.com \
    --cc=johnstul@us.ibm.com \
    --cc=kmannth@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).