[Ocfs2-devel] [PATCH 5/5] ocfs2: Remove mlog(0) from fs/ocfs2/alloc.c

[Joel Becker <Joel.Becker@oracle.com>]

On Wed, Nov 10, 2010 at 10:52:23AM +0800, Tao Ma wrote:
> So this patch removes all mlog(0,...) from alloc.c and adds
> the corresponding tracepoints. Different mlogs have different
> solutions.
> 1. Some are replaced with trace event directly.
> 2. Some are replaced and some new parameters are added since
>    I think we need to know the btree owner in that case.
> 3. Some are combined into one trace events.
> 4. Some redundant mlogs are removed.

	These decisions are what I stressed to Wengang when he did his
first pass.  I don't want to log data just because it used to have an
mlog().  We should only be logging things that are interesting.
	In this patch, I see a lot of things that make sense.  "Hey,
we're growing the tree" is a good thing to log.  So I'm not saying that
you did anything wrong.  I'm just mentioning my goals up front to be
clear.
	Overall, the patch looks good.

> What's more, it defines some event classes so that we can use
> them later.

	This is cool.

Joel

-- 

"Practice random acts of kindness and senseless acts of beauty."

 Oh, and don't forget where your towel is.

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127