From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [RFC] ocfs2: Remove j_trans_barrier
Date: Mon, 6 Dec 2010 16:45:10 -0800 [thread overview]
Message-ID: <20101207004510.GJ16687@mail.oracle.com> (raw)
In-Reply-To: <4CEF554E.2060608@oracle.com>
On Fri, Nov 26, 2010 at 02:35:58PM +0800, Tao Ma wrote:
> Hi Joel,
>
> On 11/25/2010 06:08 PM, Joel Becker wrote:
> > First, we don't always checkpoint from a downconvert. We do it
> >in clear_inode() as well, when we are flushing an inode from cache.
> >This may not have anything to do with the lock we're caring about, eg on
> >other inodes. What I mean is, the caching info for the inode we care
> >about may not be checkpointing, but the journal as a whole is. We need
> >to stop all action while that is happening.
> Sorry I don't get your last sentense. Could you please describe it
> in detail? Yes, clear_inode does do checkpointing, but actually the
> whole thing is self-contained. In ocfs2_checkpoint_inode, it can
> checkpoint the inode by itself and has no relationship with
> downconvert.
I mean that our transaction on the inode might affect other
things (like system files) that are in flux, and they could have open
stuff against them. Essentially, with JBD, I'm not sure we can trust
the state unless we freeze it. I really wish Mark could comment here,
but I think he's pretty busy.
Joel
--
"Always give your best, never get discouraged, never be petty; always
remember, others may hate you. Those who hate you don't win unless
you hate them. And then you destroy yourself."
- Richard M. Nixon
Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-12-07 0:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 6:08 [Ocfs2-devel] [RFC] ocfs2: Remove j_trans_barrier Tao Ma
2010-11-25 10:08 ` Joel Becker
2010-11-25 10:19 ` Joel Becker
2010-11-26 6:35 ` Tao Ma
2010-12-07 0:45 ` Joel Becker [this message]
2010-12-07 1:13 ` Mark Fasheh
2010-12-07 1:36 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207004510.GJ16687@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).