From: Joel Becker <jlbec@evilplan.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: optimize ocfs2_check_dir_entry() with unlikely() annotations
Date: Sun, 20 Feb 2011 04:08:28 -0800 [thread overview]
Message-ID: <20110220120828.GI17784@noexit> (raw)
In-Reply-To: <1295882610-12542-1-git-send-email-tm@tao.ma>
On Mon, Jan 24, 2011 at 11:23:30PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> In cad3f00, ext4_check_dir_entry was modified by adding some unlikely.
> Ted described it as "This function gets called a lot for large
> directories, and the answer is almost always 'no, no, there's no problem'.
> This means using unlikely() is a good thing."
> ext3 added the similar change in commit a4ae309.
>
> So change it accordingly in ocfs2.
>
> Cc: Joel Becker <jlbec@evilplan.org>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
This patch is now in the merge-window branch of ocfs2.git.
Joel
--
"Friends may come and go, but enemies accumulate."
- Thomas Jones
http://www.jlbec.org/
jlbec at evilplan.org
prev parent reply other threads:[~2011-02-20 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 15:23 [Ocfs2-devel] [PATCH] ocfs2: optimize ocfs2_check_dir_entry() with unlikely() annotations Tao Ma
2011-01-24 20:17 ` Mark Fasheh
2011-02-20 12:08 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110220120828.GI17784@noexit \
--to=jlbec@evilplan.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).