From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Date: Tue, 22 Feb 2011 13:39:28 -0800 Subject: [Ocfs2-devel] [PATCH] Treat writes as new when holes span across page boundaries In-Reply-To: References: <20110220070953.GC17784@noexit> <20110221020856.GL17784@noexit> <20110222083648.GC30966@noexit> Message-ID: <20110222213927.GA28774@noexit> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Tue, Feb 22, 2011 at 01:02:13PM -0600, Goldwyn Rodrigues wrote: > On Tue, Feb 22, 2011 at 2:36 AM, Joel Becker wrote: > > ? ? ? ?Please try the attached patch and see if it fixes the problem. > > It should work on its own, without your changes. ?If I have it wrong, > > we'll continue to evaluate the problem. ?I'd test it myself, but my VM > > setup is currently broken. > > > > It does not work. However, it shows the behavior similar to "nosparse" > without patch. So, I would say what you are targeting is achieved but > another problem resurfaces. This is because nothing zeros pages beyond > i_size in ocfs2_map_page_blocks(), since we return early because of - > > if (ret == 0 || !new) > return ret; Returning here is correct, because ret should == 0. The new part is about zeroing in the case of error. We should obviously handle it better before we get to this line. I like that we come in line nosparse and sparse. What does tailtest do for you? Does it fail or succeed? Joel -- "Here's a nickle -- get yourself a better X server." - Keith Packard http://www.jlbec.org/ jlbec at evilplan.org