ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Joel Becker <jlbec@evilplan.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] Treat writes as new when holes span across page boundaries
Date: Mon, 28 Feb 2011 10:03:02 -0800	[thread overview]
Message-ID: <20110228180301.GA13071@noexit> (raw)
In-Reply-To: <AANLkTi=3YbbK1ugAP_87HL8FJdOZVKpbJnGM5Y5MdK01@mail.gmail.com>

On Wed, Feb 23, 2011 at 04:31:25PM -0600, Goldwyn Rodrigues wrote:
> Here is a simple script. I will incorporate later into tailtest later.
> 
> FILENAME=/mnt/f2
> 
> for i in `seq 0 256`; do
> 	let s=$i*4096
> 	echo "a" | dd of=$FILENAME count=1 bs=1 seek=$s conv=notrunc 2>/dev/null
> 	let t=$s+4095
> 	echo "b" | dd of=$FILENAME count=1 bs=1 seek=$t conv=notrunc 2>/dev/null
> done

	You shouldn't need to do 256 runs.  I would like to see directed
tests that just hit one spot in a file and expose the corruption.  For
example, your described problem case should work like so:

  # Write the first three blocks of the file, getting us past inline_data
  dd if=/dev/urandom of=$FILENAME count=3 bs=4096
  # Write a byte in the next page
  dd if=/dev/urandom of=$FILENAME count=1 bs=1 seek=12228 conv=notrunc
  # Write after some partial-block portion, trying to expose failed zeroing
  dd if=/dev/urandom of=$FILENAME count=4084 bs=1 seek=12300 conv=notrunc

I would expect this to expose the problem as you've described for
clustersize >= 8K.

Joel

-- 

 Joel's First Law:

	Nature abhors a GUI.

			http://www.jlbec.org/
			jlbec at evilplan.org

  reply	other threads:[~2011-02-28 18:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-17 15:44 [Ocfs2-devel] [PATCH] Treat writes as new when holes span across page boundaries Goldwyn Rodrigues
2011-02-20  7:09 ` Joel Becker
2011-02-20 18:45   ` Goldwyn Rodrigues
2011-02-21  2:08     ` Joel Becker
2011-02-21  5:44       ` Goldwyn Rodrigues
2011-02-22  8:36         ` Joel Becker
2011-02-22  9:37           ` Joel Becker
2011-02-22 19:02           ` Goldwyn Rodrigues
2011-02-22 21:39             ` Joel Becker
2011-02-22 21:54               ` Joel Becker
2011-02-22 22:09                 ` Goldwyn Rodrigues
2011-02-22 23:34                   ` Joel Becker
2011-02-23  0:05                     ` Goldwyn Rodrigues
2011-02-23  9:39                       ` Joel Becker
2011-02-23 14:43                         ` Goldwyn Rodrigues
2011-02-23 19:13                           ` Joel Becker
2011-02-23 19:28                             ` Joel Becker
2011-02-23 21:00                               ` Goldwyn Rodrigues
2011-02-23 21:23                                 ` Joel Becker
2011-02-23 20:54                             ` Goldwyn Rodrigues
2011-02-23 21:17                               ` Joel Becker
2011-02-23 21:35                                 ` Goldwyn Rodrigues
2011-02-23 21:37                                   ` Joel Becker
2011-02-23 21:44                                     ` Joel Becker
2011-02-23 22:31                                       ` Goldwyn Rodrigues
2011-02-28 18:03                                         ` Joel Becker [this message]
2011-02-28 19:07                                           ` Goldwyn Rodrigues
2011-02-28 19:40                                             ` Joel Becker
2011-03-01  2:11                                               ` Goldwyn Rodrigues
2011-02-24 16:32                                       ` Goldwyn Rodrigues
2011-02-24 18:16                                         ` Mark Fasheh
2011-02-23 21:09                             ` Goldwyn Rodrigues
2011-02-23 21:21                               ` Joel Becker
2011-03-26 22:48 ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110228180301.GA13071@noexit \
    --to=jlbec@evilplan.org \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).