Linux ocfs2 filesystem development
 help / color / mirror / Atom feed
From: Wengang Wang <wen.gang.wang@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] avoid being purged when queued for assert_master
Date: Sat, 15 Oct 2011 18:58:02 +0800	[thread overview]
Message-ID: <20111015105802.GA2881@laptop> (raw)
In-Reply-To: <4E9877E6.8080307@oracle.com>

On 11-10-14 10:56, Sunil Mushran wrote:
> On 10/14/2011 01:57 AM, Wengang Wang wrote:
> >Problem reproduced(against mainline) with the above patch applied. Also with the hacking
> >patch(attached).
> >
> >testcase is attached.
> >
> >(kworker/u:2,14465,1):dlm_assert_master_handler:1828 ERROR: DIE! Mastery
> >assert from 0, but current owner is 1! (master)
> >lockres: master, owner=1, state=0
> >   last used: 0, refcnt: 3, on purge list: no
> >   on dirty list: no, on reco list: no, migrating pending: no
> >   inflight locks: 0, asts reserved: 0
> >   refmap nodes: [ ], inflight=0
> >   granted queue:
> >     type=5, conv=-1, node=1, cookie=1:28, ref=2, ast=(empty=y,pend=n),
> >bast=(empty=y,pend=n), pending=(conv=n,lock=n,cancel=n,unlock=n)
> >   converting queue:
> >   blocked queue:
> 
> Name the nodes such that the node numbers are obvious. Easier
> to debug that way.
> 

Yea, sorry. Node 0 is "cool", node 1 is "desk".

> This won't reproduce if you move the sleep 30000 in dlm_do_assert_master()
> after we set DLM_LOCK_RES_SETREF_INPROG. Is that correct?
You are correct, if sleep 30s after setting SETREF_INPROG, it's hard to
reproduce(no hit per my test). When SETREF_INPROG flag is set, it
prevents the refmap bit from being cleared.

While, for fixing, I don't think SETREF_INPROG can help us.

thanks,
wengang. 
 

      reply	other threads:[~2011-10-15 10:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12  7:04 [Ocfs2-devel] avoid being purged when queued for assert_master Wengang Wang
2011-10-13  0:32 ` Sunil Mushran
2011-10-13  1:02   ` Wengang Wang
2011-10-13  1:47     ` Sunil Mushran
2011-10-13  1:51       ` Wengang Wang
2011-10-13  2:07         ` Wengang Wang
2011-10-13  2:11           ` Sunil Mushran
2011-10-13  2:13             ` Wengang Wang
2011-10-13 16:09               ` Sunil Mushran
2011-10-13 23:35                 ` Wengang Wang
2011-10-13 23:37                   ` Sunil Mushran
2011-10-14  0:19                     ` Wengang Wang
2011-10-14  0:23                       ` Wengang Wang
2011-10-14  0:25                       ` Sunil Mushran
2011-10-14  8:57                         ` Wengang Wang
2011-10-14 17:56                           ` Sunil Mushran
2011-10-15 10:58                             ` Wengang Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111015105802.GA2881@laptop \
    --to=wen.gang.wang@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox