From: Joel Becker <jlbec@evilplan.org>
To: Cong Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 44/62] ocfs2: remove the second argument of k[un]map_atomic()
Date: Thu, 1 Dec 2011 12:18:46 -0800 [thread overview]
Message-ID: <20111201201846.GF1495@noexit.corp.google.com> (raw)
In-Reply-To: <1322371662-26166-45-git-send-email-amwang@redhat.com>
On Sun, Nov 27, 2011 at 01:27:24PM +0800, Cong Wang wrote:
>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
I'm presuming you'll handle pushing this with the entire series.
Joel
> ---
> fs/ocfs2/aops.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
> index c1efe93..61f93a5 100644
> --- a/fs/ocfs2/aops.c
> +++ b/fs/ocfs2/aops.c
> @@ -102,7 +102,7 @@ static int ocfs2_symlink_get_block(struct inode *inode, sector_t iblock,
> * copy, the data is still good. */
> if (buffer_jbd(buffer_cache_bh)
> && ocfs2_inode_is_new(inode)) {
> - kaddr = kmap_atomic(bh_result->b_page, KM_USER0);
> + kaddr = kmap_atomic(bh_result->b_page);
> if (!kaddr) {
> mlog(ML_ERROR, "couldn't kmap!\n");
> goto bail;
> @@ -110,7 +110,7 @@ static int ocfs2_symlink_get_block(struct inode *inode, sector_t iblock,
> memcpy(kaddr + (bh_result->b_size * iblock),
> buffer_cache_bh->b_data,
> bh_result->b_size);
> - kunmap_atomic(kaddr, KM_USER0);
> + kunmap_atomic(kaddr);
> set_buffer_uptodate(bh_result);
> }
> brelse(buffer_cache_bh);
> @@ -236,13 +236,13 @@ int ocfs2_read_inline_data(struct inode *inode, struct page *page,
> return -EROFS;
> }
>
> - kaddr = kmap_atomic(page, KM_USER0);
> + kaddr = kmap_atomic(page);
> if (size)
> memcpy(kaddr, di->id2.i_data.id_data, size);
> /* Clear the remaining part of the page */
> memset(kaddr + size, 0, PAGE_CACHE_SIZE - size);
> flush_dcache_page(page);
> - kunmap_atomic(kaddr, KM_USER0);
> + kunmap_atomic(kaddr);
>
> SetPageUptodate(page);
>
> @@ -671,7 +671,7 @@ static void ocfs2_clear_page_regions(struct page *page,
>
> ocfs2_figure_cluster_boundaries(osb, cpos, &cluster_start, &cluster_end);
>
> - kaddr = kmap_atomic(page, KM_USER0);
> + kaddr = kmap_atomic(page);
>
> if (from || to) {
> if (from > cluster_start)
> @@ -682,7 +682,7 @@ static void ocfs2_clear_page_regions(struct page *page,
> memset(kaddr + cluster_start, 0, cluster_end - cluster_start);
> }
>
> - kunmap_atomic(kaddr, KM_USER0);
> + kunmap_atomic(kaddr);
> }
>
> /*
> @@ -1928,9 +1928,9 @@ static void ocfs2_write_end_inline(struct inode *inode, loff_t pos,
> }
> }
>
> - kaddr = kmap_atomic(wc->w_target_page, KM_USER0);
> + kaddr = kmap_atomic(wc->w_target_page);
> memcpy(di->id2.i_data.id_data + pos, kaddr + pos, *copied);
> - kunmap_atomic(kaddr, KM_USER0);
> + kunmap_atomic(kaddr);
>
> trace_ocfs2_write_end_inline(
> (unsigned long long)OCFS2_I(inode)->ip_blkno,
> --
> 1.7.4.4
>
--
Life's Little Instruction Book #94
"Make it a habit to do nice things for people who
will never find out."
http://www.jlbec.org/
jlbec at evilplan.org
next parent reply other threads:[~2011-12-01 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1322371662-26166-1-git-send-email-amwang@redhat.com>
[not found] ` <1322371662-26166-45-git-send-email-amwang@redhat.com>
2011-12-01 20:18 ` Joel Becker [this message]
[not found] ` <4ED8322B.8010500@redhat.com>
2011-12-02 2:29 ` [Ocfs2-devel] [PATCH 44/62] ocfs2: remove the second argument of k[un]map_atomic() Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201201846.GF1495@noexit.corp.google.com \
--to=jlbec@evilplan.org \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox