Linux ocfs2 filesystem development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Ocfs2/move_extents: move/defrag extents within a certain range.
Date: Wed, 15 Feb 2012 20:31:59 -0000	[thread overview]
Message-ID: <20120215203151.GA17399@elgon.mountain> (raw)

Hello Tristan Ye,

This is a semi-automatic email about new static checker warnings.

The patch 53069d4e7695: "Ocfs2/move_extents: move/defrag extents 
within a certain range." from May 25, 2011, leads to the following 
Smatch complaint:

fs/ocfs2/move_extents.c:980 ocfs2_move_extents()
	 warn: variable dereferenced before check 'inode' (see line 978)

fs/ocfs2/move_extents.c
   977		struct buffer_head *di_bh = NULL;
   978		struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
                                                   ^^^^^^^^^^^
Dereference.

   979	
   980		if (!inode)
                    ^^^^^^
Check.

   981			return -ENOENT;
   982	

regards,
dan carpenter

             reply	other threads:[~2012-02-15 20:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 20:31 Dan Carpenter [this message]
2012-02-15 20:38 ` [Ocfs2-devel] Ocfs2/move_extents: move/defrag extents within a certain range Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120215203151.GA17399@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox