From: Joel Becker <jlbec@evilplan.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] ocfs2: rollback transaction in ocfs2_group_add()
Date: Fri, 27 Sep 2013 12:05:29 -0700 [thread overview]
Message-ID: <20130927190528.GH26517@localhost> (raw)
In-Reply-To: <523ECBCB.6070800@huawei.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
On Sun, Sep 22, 2013 at 06:51:55PM +0800, Younger Liu wrote:
> If ocfs2_journal_access_di fails, group->bg_next_group should rollback.
> Otherwise, there would be a inconsistency between group_bh and main_bm_bh.
>
> Signed-off-by: Younger Liu <younger.liu@huawei.com>
> ---
> fs/ocfs2/resize.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/ocfs2/resize.c b/fs/ocfs2/resize.c
> index ec55add..376750f 100644
> --- a/fs/ocfs2/resize.c
> +++ b/fs/ocfs2/resize.c
> @@ -469,6 +469,7 @@ int ocfs2_group_add(struct inode *inode, struct ocfs2_new_group_input *input)
> struct ocfs2_chain_list *cl;
> struct ocfs2_chain_rec *cr;
> u16 cl_bpc;
> + u64 bg_ptr;
>
> if (ocfs2_is_hard_readonly(osb) || ocfs2_is_soft_readonly(osb))
> return -EROFS;
> @@ -538,12 +539,14 @@ int ocfs2_group_add(struct inode *inode, struct ocfs2_new_group_input *input)
> }
>
> group = (struct ocfs2_group_desc *)group_bh->b_data;
> + bg_ptr = le64_to_cpu(group->bg_next_group);
> group->bg_next_group = cr->c_blkno;
> ocfs2_journal_dirty(handle, group_bh);
>
> ret = ocfs2_journal_access_di(handle, INODE_CACHE(main_bm_inode),
> main_bm_bh, OCFS2_JOURNAL_ACCESS_WRITE);
> if (ret < 0) {
> + group->bg_next_group = cpu_to_le64(bg_ptr);
> mlog_errno(ret);
> goto out_commit;
> }
> --
> 1.7.9.7
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
Joel's Second Law:
If a code change requires additional user setup, it is wrong.
http://www.jlbec.org/
jlbec at evilplan.org
prev parent reply other threads:[~2013-09-27 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 10:51 [Ocfs2-devel] [PATCH 1/2] ocfs2: rollback transaction in ocfs2_group_add() Younger Liu
2013-09-27 19:05 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927190528.GH26517@localhost \
--to=jlbec@evilplan.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox