From: Mark Fasheh <mfasheh@suse.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/6] Add clustername to cluster connection
Date: Sun, 3 Nov 2013 14:09:37 -0800 [thread overview]
Message-ID: <20131103220937.GG29346@wotan.suse.de> (raw)
In-Reply-To: <20131018144507.GA4574@shrek.lan>
On Fri, Oct 18, 2013 at 09:45:12AM -0500, Goldwyn Rodrigues wrote:
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 121da2d..c30ad6b 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -2225,9 +2225,9 @@ static int ocfs2_initialize_super(struct super_block *sb,
> if (ocfs2_clusterinfo_valid(osb)) {
> osb->osb_stackflags =
> OCFS2_RAW_SB(di)->s_cluster_info.ci_stackflags;
> - memcpy(osb->osb_cluster_stack,
> + strlcpy(osb->osb_cluster_stack,
> OCFS2_RAW_SB(di)->s_cluster_info.ci_stack,
> - OCFS2_STACK_LABEL_LEN);
> + OCFS2_STACK_LABEL_LEN + 1);
> osb->osb_cluster_stack[OCFS2_STACK_LABEL_LEN] = '\0';
I don't think we want to NULL terminate like this any more, right?
Otherwise the rest of this looks reasonable to me.
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2013-11-03 22:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 14:45 [Ocfs2-devel] [PATCH 1/6] Add clustername to cluster connection Goldwyn Rodrigues
2013-11-03 22:09 ` Mark Fasheh [this message]
2013-11-04 3:43 ` Goldwyn Rodrigues
-- strict thread matches above, loose matches on Subject: below --
2013-11-12 14:06 Goldwyn Rodrigues
2013-11-18 23:39 ` Mark Fasheh
2013-12-09 19:40 Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131103220937.GG29346@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox