From: Mark Fasheh <mfasheh@suse.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 2/6] Add DLM recovery callbacks
Date: Mon, 4 Nov 2013 14:09:36 -0800 [thread overview]
Message-ID: <20131104220936.GP29346@wotan.suse.de> (raw)
In-Reply-To: <52771845.2040808@suse.de>
On Sun, Nov 03, 2013 at 09:45:09PM -0600, Goldwyn Rodrigues wrote:
> On 11/03/2013 04:16 PM, Mark Fasheh wrote:
> > This also looks good in that I don't see anything wrong with the way the
> > actual code functions. The extra description you put about the callbacks
> > helps in understanding this too. Question - can you explain why oc_this_node
> > is an atomic? That is to say I'd like to understand that race that you're
> > protecting against :)
> > --Mark
>
> Ok, we may not require this to be atomic. The dlm thread sets up
> oc_this_node via .recover_done(), but it should not matter because
> this_node() functions are called after .cluster_connect().
Ahh alright. And this is probably a silly question, but we know the dlm will
never call this code concurently?
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2013-11-04 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 14:45 [Ocfs2-devel] [PATCH 2/6] Add DLM recovery callbacks Goldwyn Rodrigues
2013-11-03 22:16 ` Mark Fasheh
2013-11-04 3:45 ` Goldwyn Rodrigues
2013-11-04 22:09 ` Mark Fasheh [this message]
2013-11-05 20:34 ` Goldwyn Rodrigues
-- strict thread matches above, loose matches on Subject: below --
2013-11-12 14:06 Goldwyn Rodrigues
2013-11-25 23:00 ` Mark Fasheh
2013-12-09 19:41 Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104220936.GP29346@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox