From: Mark Fasheh <mfasheh@suse.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 6/6] Use the new DLM operation callbacks while requesting new lockspace
Date: Sun, 8 Dec 2013 11:30:34 -0800 [thread overview]
Message-ID: <20131208193034.GF16774@wotan.suse.de> (raw)
In-Reply-To: <20131112140817.GA3955@shrek.lan>
On Tue, Nov 12, 2013 at 08:08:22AM -0600, Goldwyn Rodrigues wrote:
> Attempt to use the new DLM operations. If it is not supported,
> use the traditional ocfs2_controld.
>
> To exchange ocfs2 versioning, we use the LVB of the version dlm lock.
> It first attempts to take the lock in EX mode (non-blocking). If
> successful (which means it is the first mount), it writes the
> version number and downconverts to PR lock. If it is unsuccessful,
> it reads the version from the lock.
Can you take this description of the protocol and put it (as a comment) in
or above get_protocol_version(). I kind of had to look back to the patch
description to figure out exactly what it meant to do so I figure someone
reading this int he future will have the same questions.
Otherwise this patch looks good, thanks!
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2013-12-08 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 14:08 [Ocfs2-devel] [PATCH 6/6] Use the new DLM operation callbacks while requesting new lockspace Goldwyn Rodrigues
2013-12-08 19:30 ` Mark Fasheh [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-09 19:42 Goldwyn Rodrigues
2013-10-18 14:46 Goldwyn Rodrigues
2013-11-04 1:12 ` Mark Fasheh
2013-11-04 3:48 ` Goldwyn Rodrigues
2013-11-04 22:15 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131208193034.GF16774@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox