From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Mon, 27 Jan 2014 15:07:22 -0800 Subject: [Ocfs2-devel] [patch 02/11] ocfs2: free allocated clusters if error occurs after ocfs2_claim_clusters In-Reply-To: <52E478A4.2030109@huawei.com> References: <20140124204701.6AC005A4203@corp2gmr1-2.hot.corp.google.com> <52E478A4.2030109@huawei.com> Message-ID: <20140127150722.ec1bb078cd4ae18f44ece9ae@linux-foundation.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Sun, 26 Jan 2014 10:53:24 +0800 Joseph Qi wrote: > Hi > > On 2014/1/25 4:47, akpm at linux-foundation.org wrote: > > From: Zongxun Wang > > Subject: ocfs2: free allocated clusters if error occurs after ocfs2_claim_clusters > > > > Even if using the same jbd2 handle, we cannot rollback a transaction. So > > once some error occurs after successfully allocating clusters, the > > allocated clusters will never be used and it means they are lost. For > > example, call ocfs2_claim_clusters successfully when expanding a file, but > > failed in ocfs2_insert_extent. So we need free the allocated clusters if > > they are not used indeed. > > > > We should note down num of bits to be freed, so as to update i_used > correspondingly after clearing those bits in bitmap. > I sent a patch based on this: > [PATCH] ocfs2: correctly update i_used in ocfs2_free_local_alloc_bits > https://oss.oracle.com/pipermail/ocfs2-devel/2013-November/009462.html OK thanks, I now have that, as ocfs2-free-allocated-clusters-if-error-occurs-after-ocfs2_claim_clusters-fix.patch Do we think that ocfs2-free-allocated-clusters-if-error-occurs-after-ocfs2_claim_clusters.patch and ocfs2-free-allocated-clusters-if-error-occurs-after-ocfs2_claim_clusters-fix.patch should now be merged upstream?