From: Andrew Morton <akpm@linux-foundation.org>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Dave Jones <davej@redhat.com>, Mark Fasheh <mfasheh@suse.com>,
Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@oss.oracle.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeff Liu <jeff.liu@oracle.com>
Subject: [Ocfs2-devel] [PATCH] fs: ocfs2: move_extents.c: Fix to remove null pointer checks that could never happen
Date: Thu, 29 May 2014 15:42:50 -0700 [thread overview]
Message-ID: <20140529154250.4be24a07ec68eb2eef41e8e2@linux-foundation.org> (raw)
In-Reply-To: <CAFo99gZm0b8QodT56r+wegY7LM=oWFqLmpE5cnN_MaiBrx1Fqg@mail.gmail.com>
On Fri, 30 May 2014 00:39:24 +0200 Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> wrote:
> Hi all!
>
> First, I'm no expert on this code, but after a patch which I thought
> was most accurate for the current code was written before, which was
> rather something like the code below.
> Then Jeff Liu that this was not something that could happen. So I send
> a patch where the check was removed instead.
> And that's where we are now. :-)
>
Well if Jeff says that inode==NULL cannot happen then that is the info
I was after, and the original patch is OK. Please resend, with that
important info in the changelog ;)
prev parent reply other threads:[~2014-05-29 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401222231-21656-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
2014-05-29 21:03 ` [Ocfs2-devel] [PATCH] fs: ocfs2: move_extents.c: Fix to remove null pointer checks that could never happen Andrew Morton
2014-05-29 21:23 ` Dave Jones
2014-05-29 21:38 ` Andrew Morton
[not found] ` <CAFo99gZm0b8QodT56r+wegY7LM=oWFqLmpE5cnN_MaiBrx1Fqg@mail.gmail.com>
2014-05-29 22:42 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529154250.4be24a07ec68eb2eef41e8e2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=jeff.liu@oracle.com \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).