From: Mark Fasheh <mfasheh@suse.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] Remove filesize checks for sync I/O journal commit
Date: Wed, 5 Nov 2014 13:18:07 -0800 [thread overview]
Message-ID: <20141105211807.GC27026@wotan.suse.de> (raw)
In-Reply-To: <20141104155222.GA5746@shrek.lan>
On Tue, Nov 04, 2014 at 09:52:22AM -0600, Goldwyn Rodrigues wrote:
> Filesize is not a good indication that the file needs to be synced.
> An example where this breaks is:
> 1. Open the file in O_SYNC|O_RDWR
> 2. Read a small portion of the file (say 64 bytes)
> 3. Lseek to starting of the file
> 4. Write 64 bytes
>
> If the node crashes, it is not written out to disk because this
> was not committed in the journal and the other node which reads
> the file after recovery reads stale data (even if the write on
> the other node was successful)
This patch looks good, thanks for sending it over.
Reviewed-by: Mark Fasheh <mfasheh@suse.de>
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2014-11-05 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 15:52 [Ocfs2-devel] [PATCH] Remove filesize checks for sync I/O journal commit Goldwyn Rodrigues
2014-11-04 22:45 ` Andrew Morton
2014-11-05 15:26 ` Goldwyn Rodrigues
2014-11-05 21:18 ` Mark Fasheh [this message]
2014-12-03 8:20 ` Xue jiufei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105211807.GC27026@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox