From: Dan Carpenter <dan.carpenter@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] vfs: Add general support to enforce project quota limits
Date: Mon, 13 Apr 2015 14:48:51 +0300 [thread overview]
Message-ID: <20150413114851.GP16501@mwanda> (raw)
In-Reply-To: <20150413101016.GB3633@quack.suse.cz>
Ah. Thanks for looking into it. Smatch can't understand bit flags like
that yet. And it also still doesn't track pointers very well.
Eventually those things will be improved.
I see now that this out of bounds is also prevented in
vfs_load_quota_inode(). We don't allow "(type == PRJQUOTA &&
sb->dq_op->get_projid == NULL)". Since, ->get_projid() is always NULL
for OCFS2 that means "type" can't equal to PRJQUOTA (2).
Hm.. is ->get_projid set anywhere? Cscope and smatch can't find it if
it is.
I haven't investigated v1_read_file_info() but presumably it's the same.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-13 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 19:39 [Ocfs2-devel] vfs: Add general support to enforce project quota limits Dan Carpenter
2015-04-09 19:46 ` Dan Carpenter
2015-04-13 10:10 ` Jan Kara
2015-04-13 11:48 ` Dan Carpenter [this message]
2015-04-13 12:19 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413114851.GP16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).