ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Gang He <ghe@suse.com>
Cc: mfasheh@suse.com, rgoldwyn@suse.de, linux-kernel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH v3 0/4] Add online file check feature
Date: Tue, 29 Dec 2015 13:41:11 -0800	[thread overview]
Message-ID: <20151229134111.6e0817e4b540c1fdf42d0475@linux-foundation.org> (raw)
In-Reply-To: <1451027779-6849-1-git-send-email-ghe@suse.com>

On Fri, 25 Dec 2015 15:16:15 +0800 Gang He <ghe@suse.com> wrote:

> When there are errors in the ocfs2 filesystem,
> they are usually accompanied by the inode number which caused the error.
> This inode number would be the input to fixing the file.
> One of these options could be considered:
> A file in the sys filesytem which would accept inode numbers.
> This could be used to communication back what has to be fixed or is fixed.
> You could write:
> $# echo "<inode>" > /sys/fs/ocfs2/devname/filecheck/check
> or
> $# echo "<inode>" > /sys/fs/ocfs2/devname/filecheck/fix
> 
> Compare with second version, I re-design filecheck sysfs interfaces, there
> are three sysfs files(check, fix and set) under filecheck directory(see above),
> sysfs will accept only one argument <inode>. Second, I adjust some code in 
> ocfs2_filecheck_repair_inode_block() function according to upstream feedback,
> we cannot just add VALID_FL flag back as a inode block fix, then we will not 
> fix this field corruption currently until having a complete solution.
> Compare with first version, I use strncasecmp instead of double strncmp
> functions. Second, update the source file contribution vendor.

This feature should be documented, please.  That means all pseudo-file
locations, all inputs, all outputs, expected behaviour etc etc.  Enough
info so that our users can usefully and fully use this feature in the
minimum time.  Documentation/filesystems/ocfs2.txt is the place for that.

  parent reply	other threads:[~2015-12-29 21:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-25  7:16 [Ocfs2-devel] [PATCH v3 0/4] Add online file check feature Gang He
2015-12-25  7:16 ` [Ocfs2-devel] [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check Gang He
2015-12-29 21:38   ` Andrew Morton
2015-12-30  6:13     ` Gang He
2016-01-13 23:02   ` Mark Fasheh
2016-01-13 23:07     ` Andrew Morton
2015-12-25  7:16 ` [Ocfs2-devel] [PATCH v3 2/4] ocfs2: sysfile interfaces " Gang He
2016-01-13 23:35   ` Mark Fasheh
2016-01-14  3:13     ` Gang He
2015-12-25  7:16 ` [Ocfs2-devel] [PATCH v3 3/4] ocfs2: create/remove sysfile " Gang He
2016-01-13 23:36   ` Mark Fasheh
2015-12-25  7:16 ` [Ocfs2-devel] [PATCH v3 4/4] ocfs2: check/fix inode block " Gang He
2016-01-14  1:40   ` Mark Fasheh
2016-01-14  6:30     ` Gang He
2015-12-29 21:41 ` Andrew Morton [this message]
2015-12-30  3:00   ` [Ocfs2-devel] [PATCH v3 0/4] Add online file check feature Gang He
2015-12-30  3:14     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151229134111.6e0817e4b540c1fdf42d0475@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ghe@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=rgoldwyn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).