From: Mark Fasheh <mfasheh@suse.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] add OCFS2_LOCK_IGNORE_BLOCKED arg_flags to ocfs2_cluster_lock() to prevent hang
Date: Mon, 4 Jan 2016 16:35:32 -0800 [thread overview]
Message-ID: <20160105003532.GA819@wotan.suse.de> (raw)
In-Reply-To: <568ADCC1.7090503@oracle.com>
On Mon, Jan 04, 2016 at 12:57:37PM -0800, Tariq Saeed wrote:
>
> On 12/29/2015 04:34 PM, Mark Fasheh wrote:
> > NACK - as I explained earlier on this list we need to refactor the code to
> Not sure how things work in the open source world. Is refactoring to be
> picked by
> somebody soon?
No problem, A couple explanations / notes:
1) CC me with your patches (someone had to point the last one out to me).
I'll get to reviewing most things but if you CC me then it can happen
sooner.
2) You are fixing the bug and sending the patches. We usually expect the
sender to incorporate feedback into their patch so the answer would be that
you get to to the refactoring :)
If you need to make small changes to the VFS to let this happen (sometimes
we might want 'nolock' variants of funtions, etc), do them in seperate
patches and send them along with your changes.
Hope this helps,
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2016-01-05 0:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 23:55 [Ocfs2-devel] [PATCH] add OCFS2_LOCK_IGNORE_BLOCKED arg_flags to ocfs2_cluster_lock() to prevent hang Tariq Saeed
2015-12-30 0:34 ` Mark Fasheh
2016-01-04 20:57 ` Tariq Saeed
2016-01-05 0:35 ` Mark Fasheh [this message]
2016-01-05 1:46 ` Junxiao Bi
2016-01-05 23:47 ` Joel Becker
2016-01-06 4:47 ` Junxiao Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105003532.GA819@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).