ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Mark Fasheh <mfasheh@suse.de>
To: Gang He <ghe@suse.com>
Cc: rgoldwyn@suse.de, linux-kernel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, akpm@linux-foundation.org
Subject: [Ocfs2-devel] [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check
Date: Wed, 13 Jan 2016 15:02:28 -0800	[thread overview]
Message-ID: <20160113230228.GJ819@wotan.suse.de> (raw)
In-Reply-To: <1451027779-6849-2-git-send-email-ghe@suse.com>

On Fri, Dec 25, 2015 at 03:16:16PM +0800, Gang He wrote:
> Export ocfs2_kset object from ocfs2_stackglue kernel module,
> then online file check code will create the related sysfiles
> under ocfs2_kset object.
> 
> Signed-off-by: Gang He <ghe@suse.com>

Reviewed-by: Mark Fasheh <mfasheh@suse.de>

This was easy to review, though you might consider adding a note that we're
exporting this because it's built in ocfs2_stackglue.ko.
	--Mark


> ---
>  fs/ocfs2/stackglue.c | 3 ++-
>  fs/ocfs2/stackglue.h | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
> index 5d965e8..13219ed 100644
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -629,7 +629,8 @@ static struct attribute_group ocfs2_attr_group = {
>  	.attrs = ocfs2_attrs,
>  };
>  
> -static struct kset *ocfs2_kset;
> +struct kset *ocfs2_kset;
> +EXPORT_SYMBOL_GPL(ocfs2_kset);
>  
>  static void ocfs2_sysfs_exit(void)
>  {
> diff --git a/fs/ocfs2/stackglue.h b/fs/ocfs2/stackglue.h
> index 66334a3..f2dce10 100644
> --- a/fs/ocfs2/stackglue.h
> +++ b/fs/ocfs2/stackglue.h
> @@ -298,4 +298,6 @@ void ocfs2_stack_glue_set_max_proto_version(struct ocfs2_protocol_version *max_p
>  int ocfs2_stack_glue_register(struct ocfs2_stack_plugin *plugin);
>  void ocfs2_stack_glue_unregister(struct ocfs2_stack_plugin *plugin);
>  
> +extern struct kset *ocfs2_kset;
> +
>  #endif  /* STACKGLUE_H */
> -- 
> 2.1.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
Mark Fasheh

  parent reply	other threads:[~2016-01-13 23:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-25  7:16 [Ocfs2-devel] [PATCH v3 0/4] Add online file check feature Gang He
2015-12-25  7:16 ` [Ocfs2-devel] [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check Gang He
2015-12-29 21:38   ` Andrew Morton
2015-12-30  6:13     ` Gang He
2016-01-13 23:02   ` Mark Fasheh [this message]
2016-01-13 23:07     ` Andrew Morton
2015-12-25  7:16 ` [Ocfs2-devel] [PATCH v3 2/4] ocfs2: sysfile interfaces " Gang He
2016-01-13 23:35   ` Mark Fasheh
2016-01-14  3:13     ` Gang He
2015-12-25  7:16 ` [Ocfs2-devel] [PATCH v3 3/4] ocfs2: create/remove sysfile " Gang He
2016-01-13 23:36   ` Mark Fasheh
2015-12-25  7:16 ` [Ocfs2-devel] [PATCH v3 4/4] ocfs2: check/fix inode block " Gang He
2016-01-14  1:40   ` Mark Fasheh
2016-01-14  6:30     ` Gang He
2015-12-29 21:41 ` [Ocfs2-devel] [PATCH v3 0/4] Add online file check feature Andrew Morton
2015-12-30  3:00   ` Gang He
2015-12-30  3:14     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160113230228.GJ819@wotan.suse.de \
    --to=mfasheh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ghe@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=rgoldwyn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).