From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Wed, 14 Sep 2016 15:43:24 -0700 Subject: [Ocfs2-devel] [PATCH] ocfs2: Fix start offset to ocfs2_zero_range_for_truncate() In-Reply-To: <1470957147-14185-1-git-send-email-ashish.samant@oracle.com> References: <1470957147-14185-1-git-send-email-ashish.samant@oracle.com> Message-ID: <20160914154324.c74ecfb4755e3d8958d02461@linux-foundation.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Thu, 11 Aug 2016 16:12:27 -0700 Ashish Samant wrote: > If we do fallocate with punch hole option on a reflink, with start offset > on a cluster boundary and end offset somewhere in another cluster, we > dont COW the first cluster starting at the start offset. But in this > case, we were wrongly passing this cluster to > ocfs2_zero_range_for_truncate() to zero out. > > Fix this by skipping this cluster in such a scenario. How serious is this bug? It sounds like a data-corrupting error? As such, this is a high priority fix and it should be backported into the -stable kernels? Please always include such info when fixing bugs.