From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: mfasheh@versity.com, jlbec@evilplan.org,
linux-fsdevel@vger.kernel.org, darwin.xupt@gmail.com,
zren@suse.com, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 5/7] ocfs2: don't eat io errors during _dio_end_io_write
Date: Fri, 25 Nov 2016 00:10:58 -0800 [thread overview]
Message-ID: <20161125081058.GA22465@infradead.org> (raw)
In-Reply-To: <147987579593.2678.14305853637089494031.stgit@birch.djwong.org>
On Tue, Nov 22, 2016 at 08:36:35PM -0800, Darrick J. Wong wrote:
> ocfs2_dio_end_io_write eats whatever errors may happen,
> which means that write errors do not propagate to userspace.
> Fix that.
Btw, can you also fix up the ocfs2 calling conventions for ->end_io
so that it also does the unlock for the error case in ocfs2_dio_end_io?
I looked at all the inode locking in ocfs2, but couldn't convince me
that either the current code nor the version with the locking changed
is correct..
next prev parent reply other threads:[~2016-11-25 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 4:36 [Ocfs2-devel] [PATCH v2 0/7] ocfs2: wire up {clone, copy, dedupe}_range Darrick J. Wong
2016-11-23 4:36 ` [Ocfs2-devel] [PATCH 1/7] ocfs2: convert inode refcount test to a helper Darrick J. Wong
2016-11-23 4:36 ` [Ocfs2-devel] [PATCH 2/7] ocfs2: add newlines to some error messages Darrick J. Wong
2016-11-23 4:36 ` [Ocfs2-devel] [PATCH 3/7] ocfs2: prohibit refcounted swapfiles Darrick J. Wong
2016-11-23 4:36 ` [Ocfs2-devel] [PATCH 4/7] ocfs2: budget for extent tree splits when adding refcount flag Darrick J. Wong
2016-11-23 4:36 ` [Ocfs2-devel] [PATCH 5/7] ocfs2: don't eat io errors during _dio_end_io_write Darrick J. Wong
2016-11-25 8:10 ` Christoph Hellwig [this message]
2016-11-23 4:36 ` [Ocfs2-devel] [PATCH 6/7] ocfs2: implement the VFS clone_range, copy_range, and dedupe_range features Darrick J. Wong
2016-11-25 8:18 ` Christoph Hellwig
2016-11-28 18:24 ` Darrick J. Wong
2016-11-23 4:36 ` [Ocfs2-devel] [PATCH 7/7] ocfs2: charge quota for reflinked blocks Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161125081058.GA22465@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=darwin.xupt@gmail.com \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@versity.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=zren@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox