From: Jan Kara <jack@suse.cz>
To: Tahsin Erdogan <tahsin@google.com>
Cc: Jan Kara <jack@suse.cz>, Jan Kara <jack@suse.com>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dave Kleikamp <shaggy@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Mark Fasheh <mfasheh@versity.com>,
Joel Becker <jlbec@evilplan.org>, Jens Axboe <axboe@fb.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Mike Christie <mchristi@redhat.com>,
Fabian Frederick <fabf@skynet.be>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
jfs-discussion@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com,
reiserfs-devel@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH 23/28] mbcache: make mbcache more generic
Date: Mon, 19 Jun 2017 10:50:26 +0200 [thread overview]
Message-ID: <20170619085026.GD11837@quack2.suse.cz> (raw)
In-Reply-To: <CAAeU0aMLrfhnhqzD9PH2UjHSrc64AC_85rAEz626jcuFjLXY2g@mail.gmail.com>
On Thu 15-06-17 11:25:02, Tahsin Erdogan wrote:
> On Thu, Jun 15, 2017 at 12:41 AM, Jan Kara <jack@suse.cz> wrote:
> > Can you explain a bit more what do you mean by "make it more generic" as it
> > seems you just rename a couple of things here...
>
> The change is really just that, having names that are more generic
> which do not limit use cases to block sharing. In a subsequent patch
> in the series ("[PATCH v4 27/28] ext4: xattr inode deduplication"), we
> start using the mbcache code to share xattr inodes. With that patch,
> old mb_cache_entry.e_block field could be holding either a block
> number or an inode number, so I renamed things to make them more
> generic.
OK, then I'd suggest to change title to "mbcache: make mbcache naming more
generic" and explain what you wrote here in the changelog. Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-06-19 8:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170531081517.11438-1-tahsin@google.com>
[not found] ` <20170531081517.11438-27-tahsin@google.com>
2017-05-31 15:40 ` [Ocfs2-devel] [PATCH 27/28] ext4: xattr inode deduplication kbuild test robot
2017-05-31 15:50 ` kbuild test robot
2017-05-31 16:00 ` Darrick J. Wong
[not found] ` <20170531223357.800-1-tahsin@google.com>
2017-06-02 5:41 ` [Ocfs2-devel] [PATCH v2 " Darrick J. Wong
[not found] ` <CAAeU0aN+Ts=SqGFEMOer=rguprDNX4Mo1Eyj+j1Y=dd-zdbkZw@mail.gmail.com>
2017-06-02 17:59 ` Darrick J. Wong
[not found] ` <20170531081517.11438-9-tahsin@google.com>
2017-05-31 16:03 ` [Ocfs2-devel] [PATCH 09/28] ext4: extended attribute value size limit is enforced by vfs Darrick J. Wong
[not found] ` <20170531081517.11438-7-tahsin@google.com>
2017-05-31 16:12 ` [Ocfs2-devel] [PATCH 07/28] ext4: call journal revoke when freeing ea_inode blocks Darrick J. Wong
2017-05-31 16:42 ` [Ocfs2-devel] [PATCH 01/28] ext4: xattr-in-inode support Darrick J. Wong
[not found] ` <20170531081517.11438-23-tahsin@google.com>
2017-06-15 7:41 ` [Ocfs2-devel] [PATCH 23/28] mbcache: make mbcache more generic Jan Kara
[not found] ` <CAAeU0aMLrfhnhqzD9PH2UjHSrc64AC_85rAEz626jcuFjLXY2g@mail.gmail.com>
2017-06-19 8:50 ` Jan Kara [this message]
[not found] ` <20170531081517.11438-28-tahsin@google.com>
2017-06-15 7:57 ` [Ocfs2-devel] [PATCH 28/28] quota: add extra inode count to dquot transfer functions Jan Kara
[not found] ` <CAAeU0aNgon_ERWyUNmAGaBCuk3dU9qAxA7QnZ4D8cb5g6JZcPg@mail.gmail.com>
2017-06-19 9:03 ` Jan Kara
[not found] ` <CAAeU0aM=QDb-iCnr5KVatQmmbQy8A7XmbyFBttK72SGt3oNTUg@mail.gmail.com>
2017-06-19 12:36 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619085026.GD11837@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@fb.com \
--cc=deepa.kernel@gmail.com \
--cc=fabf@skynet.be \
--cc=jack@suse.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=mfasheh@versity.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=tahsin@google.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox