From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 11 Oct 2018 06:39:34 -0700 Subject: [Ocfs2-devel] [PATCH 01/25] xfs: add a per-xfs trace_printk macro In-Reply-To: <153923114361.5546.11838344265359068530.stgit@magnolia> References: <153923113649.5546.9840926895953408273.stgit@magnolia> <153923114361.5546.11838344265359068530.stgit@magnolia> Message-ID: <20181011133934.GA23424@infradead.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Darrick J. Wong" Cc: david@fromorbit.com, sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com On Wed, Oct 10, 2018 at 09:12:23PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Add a "xfs_tprintk" macro so that developers can use trace_printk to > print out arbitrary debugging information with the XFS device name > attached to the trace output. I can't say I'm a fan of this. trace_printk is a debugging aid, and opencoding the file system name really isn't much of a burden.