From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Tue, 18 Feb 2020 15:47:30 +1100 Subject: [Ocfs2-devel] [PATCH v6 01/19] mm: Return void from various readahead functions In-Reply-To: <20200217184613.19668-2-willy@infradead.org> References: <20200217184613.19668-1-willy@infradead.org> <20200217184613.19668-2-willy@infradead.org> Message-ID: <20200218044730.GF10776@dread.disaster.area> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org On Mon, Feb 17, 2020 at 10:45:42AM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > ondemand_readahead has two callers, neither of which use the return value. > That means that both ra_submit and __do_page_cache_readahead() can return > void, and we don't need to worry that a present page in the readahead > window causes us to return a smaller nr_pages than we ought to have. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david at fromorbit.com