From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Tue, 18 Feb 2020 16:14:35 +1100 Subject: [Ocfs2-devel] [PATCH v6 05/19] mm: Remove 'page_offset' from readahead loop In-Reply-To: <20200217184613.19668-8-willy@infradead.org> References: <20200217184613.19668-1-willy@infradead.org> <20200217184613.19668-8-willy@infradead.org> Message-ID: <20200218051435.GK10776@dread.disaster.area> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org On Mon, Feb 17, 2020 at 10:45:48AM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Eliminate the page_offset variable which was confusing with the > 'offset' parameter and record the start of each consecutive run of > pages in the readahead_control. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/readahead.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Looks ok, but having the readahead dispatch out of line from the case that triggers it makes it hard to follow. Cheers, Dave. -- Dave Chinner david at fromorbit.com