From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joseph Qi Date: Tue, 20 Oct 2020 09:20:10 +0800 Subject: [Ocfs2-devel] [PATCH] fs: ocfs2 remove unneeded break In-Reply-To: <20201019175216.2329-1-trix@redhat.com> References: <20201019175216.2329-1-trix@redhat.com> Message-ID: <3e773fac-6403-560a-45d6-af949deef453@linux.alibaba.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: trix@redhat.com, mark@fasheh.com, jlbec@evilplan.org, davem@davemloft.net, akpm@linux-foundation.org, willy@infradead.org, alex.shi@linux.alibaba.com Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org On 2020/10/20 01:52, trix at redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a goto > > Signed-off-by: Tom Rix Acked-by: Joseph Qi > --- > fs/ocfs2/cluster/tcp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c > index 79a231719460..3bd8119bed5e 100644 > --- a/fs/ocfs2/cluster/tcp.c > +++ b/fs/ocfs2/cluster/tcp.c > @@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc, > msglog(hdr, "bad magic\n"); > ret = -EINVAL; > goto out; > - break; > } > > /* find a handler for it */ >