From: Sunil Mushran <Sunil.Mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2: Add cluster lock stats at the fs level
Date: Thu, 10 Apr 2008 15:56:31 -0700 [thread overview]
Message-ID: <47FE9B1F.1080201@oracle.com> (raw)
In-Reply-To: <20080410220019.GZ21261@wotan.suse.de>
How about I add another config OCFS2_ENABLE_STATS? OCFS2_DEBUG_FS
is truly debugging that has no place in a prod env while this is
could potentially be very useful in the same env.
Mark Fasheh wrote:
> On Wed, Apr 02, 2008 at 04:16:28PM -0700, Sunil Mushran wrote:
>
>> This patch adds code to track the number of times the fs takes
>> various cluster locks as well as the times associated with it.
>>
>
> Ok, this is definitely some usefull stuff. I'm concerned about how much it
> grows struct ocfs2_lock_res though - I count 52 bytes. Even if the overhead
> doesn't technically push it out to another slab, that's still a lot. Can we
> wrap enough of this in OCFS2_DEBUG_FS so that the overhead can be easily
> compiled out?
> --Mark
>
> --
> Mark Fasheh
>
next prev parent reply other threads:[~2008-04-10 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 23:16 [Ocfs2-devel] [PATCH 1/1] ocfs2: Add cluster lock stats at the fs level Sunil Mushran
2008-04-10 22:00 ` Mark Fasheh
2008-04-10 22:56 ` Sunil Mushran [this message]
2008-04-10 23:15 ` Mark Fasheh
2008-04-10 23:24 ` Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FE9B1F.1080201@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).