* [Ocfs2-devel] [2.6 patch] ocfs2/dlm/dlmdebug.c: make 2 functions static
@ 2008-04-21 8:49 Adrian Bunk
2008-04-21 17:16 ` Sunil Mushran
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-04-21 8:49 UTC (permalink / raw)
To: Joel Becker, Mark Fasheh; +Cc: ocfs2-devel, linux-kernel
This patch makes the following needlessly global functions static:
- stringify_lockname()
- dlm_debug_put()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
fs/ocfs2/dlm/dlmdebug.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
fec83555cf8467e5c932fa52177b8f567eb84d94 diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c
index 5f6d858..1b81dcb 100644
--- a/fs/ocfs2/dlm/dlmdebug.c
+++ b/fs/ocfs2/dlm/dlmdebug.c
@@ -44,7 +44,8 @@
#define MLOG_MASK_PREFIX ML_DLM
#include "cluster/masklog.h"
-int stringify_lockname(const char *lockname, int locklen, char *buf, int len);
+static int stringify_lockname(const char *lockname, int locklen, char *buf,
+ int len);
void dlm_print_one_lock_resource(struct dlm_lock_resource *res)
{
@@ -251,7 +252,8 @@ EXPORT_SYMBOL_GPL(dlm_errname);
*
* For more on lockname formats, please refer to dlmglue.c and ocfs2_lockid.h.
*/
-int stringify_lockname(const char *lockname, int locklen, char *buf, int len)
+static int stringify_lockname(const char *lockname, int locklen, char *buf,
+ int len)
{
int out = 0;
__be64 inode_blkno_be;
@@ -368,7 +370,7 @@ static void dlm_debug_free(struct kref *kref)
kfree(dc);
}
-void dlm_debug_put(struct dlm_debug_ctxt *dc)
+static void dlm_debug_put(struct dlm_debug_ctxt *dc)
{
if (dc)
kref_put(&dc->debug_refcnt, dlm_debug_free);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Ocfs2-devel] [2.6 patch] ocfs2/dlm/dlmdebug.c: make 2 functions static
2008-04-21 8:49 [Ocfs2-devel] [2.6 patch] ocfs2/dlm/dlmdebug.c: make 2 functions static Adrian Bunk
@ 2008-04-21 17:16 ` Sunil Mushran
0 siblings, 0 replies; 2+ messages in thread
From: Sunil Mushran @ 2008-04-21 17:16 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Joel Becker, Mark Fasheh, linux-kernel, ocfs2-devel
Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - stringify_lockname()
> - dlm_debug_put()
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Acked-by: Sunil Mushran <sunil.mushran@oracle.com>
> ---
>
> fs/ocfs2/dlm/dlmdebug.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> fec83555cf8467e5c932fa52177b8f567eb84d94 diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c
> index 5f6d858..1b81dcb 100644
> --- a/fs/ocfs2/dlm/dlmdebug.c
> +++ b/fs/ocfs2/dlm/dlmdebug.c
> @@ -44,7 +44,8 @@
> #define MLOG_MASK_PREFIX ML_DLM
> #include "cluster/masklog.h"
>
> -int stringify_lockname(const char *lockname, int locklen, char *buf, int len);
> +static int stringify_lockname(const char *lockname, int locklen, char *buf,
> + int len);
>
> void dlm_print_one_lock_resource(struct dlm_lock_resource *res)
> {
> @@ -251,7 +252,8 @@ EXPORT_SYMBOL_GPL(dlm_errname);
> *
> * For more on lockname formats, please refer to dlmglue.c and ocfs2_lockid.h.
> */
> -int stringify_lockname(const char *lockname, int locklen, char *buf, int len)
> +static int stringify_lockname(const char *lockname, int locklen, char *buf,
> + int len)
> {
> int out = 0;
> __be64 inode_blkno_be;
> @@ -368,7 +370,7 @@ static void dlm_debug_free(struct kref *kref)
> kfree(dc);
> }
>
> -void dlm_debug_put(struct dlm_debug_ctxt *dc)
> +static void dlm_debug_put(struct dlm_debug_ctxt *dc)
> {
> if (dc)
> kref_put(&dc->debug_refcnt, dlm_debug_free);
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-21 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-21 8:49 [Ocfs2-devel] [2.6 patch] ocfs2/dlm/dlmdebug.c: make 2 functions static Adrian Bunk
2008-04-21 17:16 ` Sunil Mushran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).