ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Tao Ma <tao.ma@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH]ocfs2-1.2: Add dput for uuid entry.
Date: Wed, 07 May 2008 17:23:32 +0800	[thread overview]
Message-ID: <48217514.9040808@oracle.com> (raw)
In-Reply-To: <482172FD.3040404@oracle.com>

aha, sorry for the noise. :(

dput is added in the next commit 29a7f3ada7fea5510504c5359c3f70d109aeb055.
http://www.uwsg.indiana.edu/hypermail/linux/kernel/0611.3/0126.html

So here my question is should we patch these 2 patches into our 
ocfs2-1.2 or just the 1st one?

Regards,
Tao

Tao Ma wrote:
> Some more information.
> The git commit log in the kernel is: 
> 65c333367b1aea57d58168ad3dc1df27b0227401
> http://www.uwsg.indiana.edu/hypermail/linux/kernel/0611.3/0125.html.
> 
> In this patch the debugfs_remove is modified(dput is removed), but in 
> the latest fs/debugfs/inode.c, dput is still there. So now I really 
> don't know whether this function should be modified or not.
> 
> Any advice is welcomed.
> Thanks.
> 
> Regards,
> Tao
> 
> Tao Ma wrote:
>> In ocfs2-1.2, when we mount a device, a debugfs dir will be created 
>> using its uuid. When 2 devices have the same uuid, after the 1st 
>> device is mounted, the 2nd one can't be mounted. This is OK. But the 
>> problem is that the dentry's reference is added. So when the 1st 
>> volume is umounted, none of these 2 volumes can be mounted then. So 
>> this fix solves this problem by dputting the entry(Copied from the 
>> latest debugfs code in Linux kernel).
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Ocfs2-devel mailing list
>> Ocfs2-devel at oss.oracle.com
>> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
> 

  reply	other threads:[~2008-05-07  9:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07  6:48 [Ocfs2-devel] [PATCH]ocfs2-1.2: Add dput for uuid entry Tao Ma
2008-05-07  9:14 ` Tao Ma
2008-05-07  9:23   ` Tao Ma [this message]
2008-05-07 18:04     ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48217514.9040808@oracle.com \
    --to=tao.ma@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).