ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] Ocfs2: Add macro OCFS2_VOL_UUIDSTR_LEN in ocfs2_fs.h
Date: Tue, 20 Apr 2010 15:34:43 -0700	[thread overview]
Message-ID: <4BCE2C03.5000506@oracle.com> (raw)
In-Reply-To: <20100420223223.GB9423@mail.oracle.com>

True. I had asked Tristan to put it in ocfs2.h

Joel Becker wrote:
> On Tue, Apr 20, 2010 at 02:59:02PM +0800, Tristan Ye wrote:
>   
>> Since we've been using uuid_str in most of ocfs2 codes, adding
>> such a macro would be helpful.
>>
>> Signed-off-by: Tristan Ye <tristan.ye@oracle.com>
>> ---
>>  fs/ocfs2/ocfs2_fs.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
>> index bb37218..b313c83 100644
>> --- a/fs/ocfs2/ocfs2_fs.h
>> +++ b/fs/ocfs2/ocfs2_fs.h
>> @@ -274,6 +274,7 @@
>>  
>>  #define OCFS2_VOL_UUID_LEN		16
>>  #define OCFS2_MAX_VOL_LABEL_LEN		64
>> +#define OCFS2_VOL_UUIDSTR_LEN		(OCFS2_VOL_UUID_LEN * 2 + 1)
>>     
>
> 	Also, why is this in ocfs2_fs.h?  It's not a structural
> feature.
>
> Joel
>
>   

  reply	other threads:[~2010-04-20 22:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20  6:59 [Ocfs2-devel] [PATCH 1/2] Ocfs2: Add macro OCFS2_VOL_UUIDSTR_LEN in ocfs2_fs.h Tristan Ye
2010-04-20  6:59 ` [Ocfs2-devel] [PATCH 2/2] Ocfs2: Add new OCFS2_IOC_INFO ioctl for ocfs2 v7 Tristan Ye
2010-04-20 20:31   ` Sunil Mushran
2010-04-20 20:26 ` [Ocfs2-devel] [PATCH 1/2] Ocfs2: Add macro OCFS2_VOL_UUIDSTR_LEN in ocfs2_fs.h Sunil Mushran
2010-04-20 22:14 ` Joel Becker
2010-04-20 22:32 ` Joel Becker
2010-04-20 22:34   ` Sunil Mushran [this message]
2010-04-20 22:48     ` Sunil Mushran
2010-04-21  1:40       ` tristan
2010-04-21  1:44         ` tristan
2010-04-21 18:32         ` Sunil Mushran
2010-04-22 10:18           ` Joel Becker
2010-04-21  1:37     ` tristan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCE2C03.5000506@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).