From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sunil Mushran <sunil.mushran@oracle.com>
Date: Tue, 20 Apr 2010 15:34:43 -0700
Subject: [Ocfs2-devel] [PATCH 1/2] Ocfs2: Add macro
 OCFS2_VOL_UUIDSTR_LEN in ocfs2_fs.h
In-Reply-To: <20100420223223.GB9423@mail.oracle.com>
References: <1271746743-17653-1-git-send-email-tristan.ye@oracle.com>
	<20100420223223.GB9423@mail.oracle.com>
Message-ID: <4BCE2C03.5000506@oracle.com>
List-Id: <ocfs2-devel.oss.oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ocfs2-devel@oss.oracle.com

True. I had asked Tristan to put it in ocfs2.h

Joel Becker wrote:
> On Tue, Apr 20, 2010 at 02:59:02PM +0800, Tristan Ye wrote:
>   
>> Since we've been using uuid_str in most of ocfs2 codes, adding
>> such a macro would be helpful.
>>
>> Signed-off-by: Tristan Ye <tristan.ye@oracle.com>
>> ---
>>  fs/ocfs2/ocfs2_fs.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
>> index bb37218..b313c83 100644
>> --- a/fs/ocfs2/ocfs2_fs.h
>> +++ b/fs/ocfs2/ocfs2_fs.h
>> @@ -274,6 +274,7 @@
>>  
>>  #define OCFS2_VOL_UUID_LEN		16
>>  #define OCFS2_MAX_VOL_LABEL_LEN		64
>> +#define OCFS2_VOL_UUIDSTR_LEN		(OCFS2_VOL_UUID_LEN * 2 + 1)
>>     
>
> 	Also, why is this in ocfs2_fs.h?  It's not a structural
> feature.
>
> Joel
>
>