[Ocfs2-devel] [PATCH 1/2] Ocfs2: Add macro OCFS2_VOL_UUIDSTR_LEN in ocfs2_fs.h

[tristan <tristan.ye@oracle.com>]

tristan wrote:
> Sunil Mushran wrote:
>> ok. So how about we remove this #define totally and have
>> the ioctl interface return the binary uuid. The o2info tool
>> can convert do the conversion.
>
> But... returning binary uuid from o2info was not that easy, ocfs2 
> in-memory super_block osb only successfully initialized the osb->uuid, 
> while did nothing to uuid_str, I remembered we've been discussing on 
> that issue:

Oh, sorry for the typo here , I meant it successfully initialized 
osb->uuid_str, while did nothing to osb->uuid.


>
> http://oss.oracle.com/pipermail/ocfs2-devel/2009-November/005514.html
>
>
> That patch was not adopted, and we're still using uuid_str in most places.
>
>
> Tristan.
>
>> Sunil Mushran wrote:
>>> True. I had asked Tristan to put it in ocfs2.h
>>>
>>> Joel Becker wrote:
>>>> On Tue, Apr 20, 2010 at 02:59:02PM +0800, Tristan Ye wrote:
>>>>> Since we've been using uuid_str in most of ocfs2 codes, adding
>>>>> such a macro would be helpful.
>>>>>
>>>>> Signed-off-by: Tristan Ye <tristan.ye@oracle.com>
>>>>> ---
>>>>> fs/ocfs2/ocfs2_fs.h | 1 +
>>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
>>>>> index bb37218..b313c83 100644
>>>>> --- a/fs/ocfs2/ocfs2_fs.h
>>>>> +++ b/fs/ocfs2/ocfs2_fs.h
>>>>> @@ -274,6 +274,7 @@
>>>>>
>>>>> #define OCFS2_VOL_UUID_LEN 16
>>>>> #define OCFS2_MAX_VOL_LABEL_LEN 64
>>>>> +#define OCFS2_VOL_UUIDSTR_LEN (OCFS2_VOL_UUID_LEN * 2 + 1)
>>>> Also, why is this in ocfs2_fs.h? It's not a structural
>>>> feature.
>>>>
>>>> Joel
>>>>
>>>
>>> _______________________________________________
>>> Ocfs2-devel mailing list
>>> Ocfs2-devel at oss.oracle.com
>>> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel