From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/dlm: remove unreasonable BUG_ON()
Date: Tue, 25 May 2010 19:27:03 -0700 [thread overview]
Message-ID: <4BFC86F7.6030406@oracle.com> (raw)
In-Reply-To: <20100526015417.GA2537@laptop.us.oracle.com>
On 05/25/2010 06:54 PM, Wengang Wang wrote:
> On 10-05-25 10:22, Sunil Mushran wrote:
>
>> NAK
>>
>> How did this lockres get into the dirty list? The dlm only adds locks that
>> it owns to that list. And such locks, by definition, can never be in the
>> recovery list.
>>
> Yes that my description is not good.
>
> Actually, I hit the BUG_ON(res->owner != dlm->node_num); during some tests.
>
> When an recovery happened, the lockres' that is owned by the "dead" node is
> marked as in recovery and the owner is set as unknown. But note that a lockres
> owned by this node can also be marked as in recovery(and owner changed to
> unknown). That can happen when a migration for the lockres is in progress with
> the "dead" node. see dlm_clean_master_list().
>
> So it's that the owner changed from dlm->node_num to unknown when the
> lockres is already on the list.
>
Ok. That needs fixing. But it's a lot more involved than this. I had
discussed this with Srini some time back.
next prev parent reply other threads:[~2010-05-26 2:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 10:57 [Ocfs2-devel] [PATCH] ocfs2/dlm: remove unreasonable BUG_ON() Wengang Wang
2010-05-25 17:22 ` Sunil Mushran
2010-05-26 1:54 ` Wengang Wang
2010-05-26 2:27 ` Sunil Mushran [this message]
2010-06-11 10:26 ` Wengang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFC86F7.6030406@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).