ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
* [Ocfs2-devel] [PATCH -next] ocfs2: fix build for OCFS2_FS_STATS not enabled
       [not found] <20101227170451.a9a9f873.sfr@canb.auug.org.au>
@ 2010-12-27 19:55 ` Randy Dunlap
  2010-12-27 20:52   ` Joel Becker
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2010-12-27 19:55 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Fasheh, Joel Becker; +Cc: linux-next, LKML, ocfs2-devel

From: Randy Dunlap <randy.dunlap@oracle.com>

When CONFIG_OCFS2_FS_STATS is not enabled:

fs/ocfs2/cluster/tcp.c:1254: error: implicit declaration of function 'o2net_update_recv_stats'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Mark Fasheh <mfasheh@suse.com>
Cc:	Joel Becker <joel.becker@oracle.com>
Cc:	ocfs2-devel at oss.oracle.com
---
 fs/ocfs2/cluster/tcp.c |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20101227.orig/fs/ocfs2/cluster/tcp.c
+++ linux-next-20101227/fs/ocfs2/cluster/tcp.c
@@ -257,6 +257,8 @@ static void o2net_update_recv_stats(stru
 
 # define o2net_update_send_stats(a, b)
 
+# define o2net_update_recv_stats(sc)
+
 #endif /* CONFIG_OCFS2_FS_STATS */
 
 static inline int o2net_reconnect_delay(void)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Ocfs2-devel] [PATCH -next] ocfs2: fix build for OCFS2_FS_STATS not enabled
  2010-12-27 19:55 ` [Ocfs2-devel] [PATCH -next] ocfs2: fix build for OCFS2_FS_STATS not enabled Randy Dunlap
@ 2010-12-27 20:52   ` Joel Becker
  2010-12-27 21:41     ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Joel Becker @ 2010-12-27 20:52 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Stephen Rothwell, Mark Fasheh, linux-next, LKML, ocfs2-devel

On Mon, Dec 27, 2010 at 11:55:08AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> When CONFIG_OCFS2_FS_STATS is not enabled:
> 
> fs/ocfs2/cluster/tcp.c:1254: error: implicit declaration of function 'o2net_update_recv_stats'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc:	Mark Fasheh <mfasheh@suse.com>
> Cc:	Joel Becker <joel.becker@oracle.com>
> Cc:	ocfs2-devel at oss.oracle.com

Acked-by: Joel Becker <joel.becker@oracle.com>

Do you want to push it or would you like me to?

Joel

-- 

"But all my words come back to me
 In shades of mediocrity.
 Like emptiness in harmony
 I need someone to comfort me."

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Ocfs2-devel] [PATCH -next] ocfs2: fix build for OCFS2_FS_STATS not enabled
  2010-12-27 20:52   ` Joel Becker
@ 2010-12-27 21:41     ` Randy Dunlap
  0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2010-12-27 21:41 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Fasheh, linux-next, LKML, ocfs2-devel

On 12/27/10 12:52, Joel Becker wrote:
> On Mon, Dec 27, 2010 at 11:55:08AM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> When CONFIG_OCFS2_FS_STATS is not enabled:
>>
>> fs/ocfs2/cluster/tcp.c:1254: error: implicit declaration of function 'o2net_update_recv_stats'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc:	Mark Fasheh <mfasheh@suse.com>
>> Cc:	Joel Becker <joel.becker@oracle.com>
>> Cc:	ocfs2-devel at oss.oracle.com
> 
> Acked-by: Joel Becker <joel.becker@oracle.com>
> 
> Do you want to push it or would you like me to?

You, please.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts:  http://www.xenotime.net/linux/recipes/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-27 21:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20101227170451.a9a9f873.sfr@canb.auug.org.au>
2010-12-27 19:55 ` [Ocfs2-devel] [PATCH -next] ocfs2: fix build for OCFS2_FS_STATS not enabled Randy Dunlap
2010-12-27 20:52   ` Joel Becker
2010-12-27 21:41     ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).