ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Tristan Ye <tristan.ye@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 01/14] Ocfs2/refcounttree: Fix a bug for refcounttree to writeback clusters in a right number.
Date: Fri, 28 Jan 2011 09:43:24 +0800	[thread overview]
Message-ID: <4D421F3C.9010109@oracle.com> (raw)
In-Reply-To: <20110127232923.GB23899@wotan.suse.de>

Mark Fasheh wrote:
> On Fri, Jan 21, 2011 at 06:20:18PM +0800, Tristan Ye wrote:
>> Current refcounttree codes actually didn't writeback the new pages out in
>> write-back mode, due to a bug of always passing a ZERO number of clusters
>> to 'ocfs2_cow_sync_writeback', the patch tries to pass a proper one in.
>>
>> Signed-off-by: Tristan Ye <tristan.ye@oracle.com>
>
> Seems to look reasonable to me, though Joel or Tao might want to give their
> own quick SOB too.

Mark,

    Thanks for your quick review;-)

>
> Joel: I think we want this particular patch to go upstream sooner than
> later, yes?

Yep, it's more like a stand-alone fix for reflink than one part of 
defragmentation patches.

It thus will be better to have this in next 'fixes' commit.


Tristan.

>
> Signed-off-by: Mark Fasheh <mfasheh@suse.com>
> 	--Mark
>
> --
> Mark Fasheh

  reply	other threads:[~2011-01-28  1:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 10:20 [Ocfs2-devel] [PATCH 0/14] Ocfs2: Online defragmentaion V3 Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 01/14] Ocfs2/refcounttree: Fix a bug for refcounttree to writeback clusters in a right number Tristan Ye
2011-01-27 23:29   ` Mark Fasheh
2011-01-28  1:43     ` Tristan Ye [this message]
2011-02-20 10:40   ` Joel Becker
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 02/14] Ocfs2/refcounttree: Publicate couple of funcs from refcounttree.c Tristan Ye
2011-01-28  0:05   ` Mark Fasheh
2011-01-28  1:46     ` Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 03/14] Ocfs2/move_extents: Adding new ioctl code 'OCFS2_IOC_MOVE_EXT' to ocfs2 Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 04/14] Ocfs2/move_extents: Add basic framework and source files for extent moving Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 05/14] Ocfs2/move_extents: lock allocators and reserve metadata blocks and data clusters for extents moving Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 06/14] Ocfs2/move_extents: move a range of extent Tristan Ye
2011-01-28  1:10   ` Mark Fasheh
2011-01-28  1:51     ` Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 07/14] Ocfs2/move_extents: defrag " Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 08/14] Ocfs2/move_extents: find the victim alloc group, where the given #blk fits Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 09/14] Ocfs2/move_extents: helper to validate and adjust moving goal Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 10/14] Ocfs2/move_extents: helper to probe a proper region to move in an alloc group Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 11/14] Ocfs2/move_extents: helpers to update the group descriptor and global bitmap inode Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 12/14] Ocfs2/move_extents: move entire/partial extent Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 13/14] Ocfs2/move_extents: helper to calculate the defraging length in one run Tristan Ye
2011-01-21 10:20 ` [Ocfs2-devel] [PATCH 14/14] Ocfs2/move_extents: move/defrag extents within a certain range Tristan Ye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D421F3C.9010109@oracle.com \
    --to=tristan.ye@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).