From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] ocfs2/cluster: Heartbeat mismatch message improved
Date: Tue, 22 Feb 2011 18:21:40 -0800 [thread overview]
Message-ID: <4D646F34.5040201@oracle.com> (raw)
In-Reply-To: <20110222093427.GG30966@noexit>
On 02/22/2011 01:34 AM, Joel Becker wrote:
> On Mon, Feb 21, 2011 at 02:25:24PM -0800, Sunil Mushran wrote:
>> If o2hb finds unexpected values in the heartbeat slot, it prints a message
>> "ERROR: Device "dm-6": another node is heartbeating in our slot!"
>>
>> This patch adds more information allowing us to see the actual mismatch.
>> The new message reads "ERROR: Heartbeat mismatch on "dm-6": expected(92:0x234543,
>> 0x76567) ondisk(92:0x234543, 0x76565)"
> Can you still say 'another node is heartbeating in our slot',
> just with the detail? The new message doesn't give a clue as to what is
> happening.
OK. I'll improve on the message.
prev parent reply other threads:[~2011-02-23 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 22:25 [Ocfs2-devel] [PATCH 1/2] ocfs2/cluster: Heartbeat mismatch message improved Sunil Mushran
2011-02-21 22:25 ` [Ocfs2-devel] [PATCH 2/2] ocfs2/dlm: Move kmalloc() outside the spinlock Sunil Mushran
2011-02-22 9:36 ` Joel Becker
2011-02-22 9:34 ` [Ocfs2-devel] [PATCH 1/2] ocfs2/cluster: Heartbeat mismatch message improved Joel Becker
2011-02-23 2:21 ` Sunil Mushran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D646F34.5040201@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).