From: Tiger Yang <tiger.yang@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2: clean up mount option about atime in ocfs2.txt
Date: Mon, 28 Mar 2011 16:50:30 +0800 [thread overview]
Message-ID: <4D904BD6.3030104@oracle.com> (raw)
In-Reply-To: <20110326214403.GB8837@noexit>
On 03/27/2011 05:44 AM, Joel Becker wrote:
> On Wed, Mar 02, 2011 at 07:32:09PM +0800, Tiger Yang wrote:
>> - if (osb->s_atime_quantum != OCFS2_DEFAULT_ATIME_QUANTUM)
>> + if (!(mnt->mnt_flags& MNT_NOATIME)&& !(mnt->mnt_flags& MNT_RELATIME))
>> seq_printf(s, ",atime_quantum=%u", osb->s_atime_quantum);
> I can see why you don't print in the case of noatime or
> relatime, but you should keep the check for DEFAULT_ATIME_QUANTUM.
> There's no point in printing it if it is the default.
Hi, Joel,
I have thought this issue, I choose to show the quantum value when user
mount with strictatime, because we don't as "strict" as the other file
system to update atime by default. If we don't show the default quantum
value, that may be confuse the new user to ocfs2.
Thanks,
tiger
next prev parent reply other threads:[~2011-03-28 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 11:27 [Ocfs2-devel] [PATCH 0/2] support strictatime in ocfs2 Tiger Yang
2011-03-02 11:30 ` [Ocfs2-devel] [PATCH 1/1] ocfs2-tools: " Tiger Yang
2011-03-26 21:42 ` Joel Becker
2011-03-28 8:37 ` Tiger Yang
2011-03-02 11:32 ` [Ocfs2-devel] [PATCH 1/1] ocfs2: clean up mount option about atime in ocfs2.txt Tiger Yang
2011-03-26 21:44 ` Joel Becker
2011-03-28 8:50 ` Tiger Yang [this message]
2011-05-24 6:56 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D904BD6.3030104@oracle.com \
--to=tiger.yang@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).