From: Tao Ma <tm@tao.ma>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Maybe a null point bug in __ocfs2_change_file_space.
Date: Fri, 13 Apr 2012 17:26:52 +0800 [thread overview]
Message-ID: <4F87F15C.9080009@tao.ma> (raw)
In-Reply-To: <6A84A23BB58148AEAFD0504349CC2A0D@c00148h>
Hi Limin,
Thanks for the report and the patch is already there. Please search the
archive with the subject "ocfs2: Fix oops in fallocate()".
Thanks
Tao
On 04/13/2012 03:58 PM, Chang Limin wrote:
> Hi,
>
> Version linux-3.3
>
> In function
>
> static long ocfs2_fallocate(struct file *file, int mode, loff_t offset,
>
> loff_t len)
>
> {
>
> ?
>
> return __ocfs2_change_file_space(NULL, inode, offset, cmd,
> &sr, // file is NULL
>
> change_size);
>
> }
>
>
>
> In function
>
> static int __ocfs2_change_file_space(struct file *file, struct inode *inode,
>
> loff_t f_pos, unsigned int cmd,
>
> struct ocfs2_space_resv *sr,
>
> int change_size)
>
> {
>
> if (file->f_flags &
> O_SYNC)
> // access file->f_flags result null pointer
>
> handle->h_sync = 1;
>
> }
>
>
>
> Changlimin
next prev parent reply other threads:[~2012-04-13 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 7:58 [Ocfs2-devel] Maybe a null point bug in __ocfs2_change_file_space Chang Limin
2012-04-13 9:26 ` Tao Ma [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-13 3:32 Chang Limin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F87F15C.9080009@tao.ma \
--to=tm@tao.ma \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox