From: Jeff Liu <jeff.liu@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [patch 22/22] ocfs2: remove unused variable ip in dlmfs_get_root_inode()
Date: Thu, 29 Aug 2013 17:54:37 +0800 [thread overview]
Message-ID: <521F1A5D.7020003@oracle.com> (raw)
In-Reply-To: <20130827210516.E4DC95A4276@corp2gmr1-2.hot.corp.google.com>
On 08/28/2013 05:05 AM, akpm at linux-foundation.org wrote:
> From: Joseph Qi <joseph.qi@huawei.com>
> Subject: ocfs2: remove unused variable ip in dlmfs_get_root_inode()
>
> Variable ip in dlmfs_get_root_inode() is defined but not used. So clean
> it up.
>
> Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Looks good. Reviewed-by: Jie Liu <jeff.liu@oracle.com>
> ---
>
> fs/ocfs2/dlmfs/dlmfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff -puN fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode fs/ocfs2/dlmfs/dlmfs.c
> --- a/fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode
> +++ a/fs/ocfs2/dlmfs/dlmfs.c
> @@ -401,11 +401,8 @@ static struct inode *dlmfs_get_root_inod
> {
> struct inode *inode = new_inode(sb);
> umode_t mode = S_IFDIR | 0755;
> - struct dlmfs_inode_private *ip;
>
> if (inode) {
> - ip = DLMFS_I(inode);
> -
> inode->i_ino = get_next_ino();
> inode_init_owner(inode, NULL, mode);
> inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info;
> _
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
prev parent reply other threads:[~2013-08-29 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 21:05 [Ocfs2-devel] [patch 22/22] ocfs2: remove unused variable ip in dlmfs_get_root_inode() akpm at linux-foundation.org
2013-08-29 9:54 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F1A5D.7020003@oracle.com \
--to=jeff.liu@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox