From: Jeff Liu <jeff.liu@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Remove some redundant casting
Date: Wed, 14 May 2014 10:51:14 +0800 [thread overview]
Message-ID: <5372DA22.90805@oracle.com> (raw)
In-Reply-To: <20140509224508.27912.qmail@ns.horizon.com>
Tao's Oracle email address was obsolete.
On 05/10/2014 06:45 AM, George Spelvin wrote:
> There are two standard techniques for dereferencing structures pointed
> to by void *: cast to the right type each time they're used, or assign
> to local variables of the right type.
>
> But there's no need to do *both*.
>
> Signed-off-by: George Spelvin <linux@horizon.com>
> ---
> Obviously, this makes zero difference to the generated code, but
> it's prettier.
Indeed :), the patch looks good to me.
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
prev parent reply other threads:[~2014-05-14 2:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 22:45 [Ocfs2-devel] [PATCH] ocfs2: Remove some redundant casting George Spelvin
2014-05-14 2:51 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5372DA22.90805@oracle.com \
--to=jeff.liu@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).