* [Ocfs2-devel] [PATCH] fs: ocfs2: dir.c: Cleaning up uninitialized variables
[not found] <1401630784-20493-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
@ 2014-06-02 18:44 ` Srinivas Eeda
2014-06-02 20:22 ` Andrew Morton
1 sibling, 0 replies; 2+ messages in thread
From: Srinivas Eeda @ 2014-06-02 18:44 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Mark Fasheh, Joel Becker, ocfs2-devel, linux-kernel, akpm
Acked-by: Srinivas Eeda <srinivas.eeda@oracle.com>
On 06/01/2014 06:53 AM, Rickard Strandqvist wrote:
> There is a risk that the variable will be used without being initialized.
>
> This was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> fs/ocfs2/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
> index 0717662..27aa4a1 100644
> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -3738,7 +3738,7 @@ static int ocfs2_dx_dir_rebalance(struct ocfs2_super *osb, struct inode *dir,
> int credits, ret, i, num_used, did_quota = 0;
> u32 cpos, split_hash, insert_hash = hinfo->major_hash;
> u64 orig_leaves_start;
> - int num_dx_leaves;
> + int num_dx_leaves = 0;
> struct buffer_head **orig_dx_leaves = NULL;
> struct buffer_head **new_dx_leaves = NULL;
> struct ocfs2_alloc_context *data_ac = NULL, *meta_ac = NULL;
^ permalink raw reply [flat|nested] 2+ messages in thread* [Ocfs2-devel] [PATCH] fs: ocfs2: dir.c: Cleaning up uninitialized variables
[not found] <1401630784-20493-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
2014-06-02 18:44 ` [Ocfs2-devel] [PATCH] fs: ocfs2: dir.c: Cleaning up uninitialized variables Srinivas Eeda
@ 2014-06-02 20:22 ` Andrew Morton
1 sibling, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2014-06-02 20:22 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: Mark Fasheh, Joel Becker, ocfs2-devel, linux-kernel
On Sun, 1 Jun 2014 15:53:04 +0200 Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> wrote:
> There is a risk that the variable will be used without being initialized.
um, no there isn't.
> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -3738,7 +3738,7 @@ static int ocfs2_dx_dir_rebalance(struct ocfs2_super *osb, struct inode *dir,
> int credits, ret, i, num_used, did_quota = 0;
> u32 cpos, split_hash, insert_hash = hinfo->major_hash;
> u64 orig_leaves_start;
> - int num_dx_leaves;
> + int num_dx_leaves = 0;
> struct buffer_head **orig_dx_leaves = NULL;
> struct buffer_head **new_dx_leaves = NULL;
> struct ocfs2_alloc_context *data_ac = NULL, *meta_ac = NULL;
If ocfs2_dx_dir_kmalloc_leaves() returns non-zero, num_dx_leaves will
have been initialized.
^ permalink raw reply [flat|nested] 2+ messages in thread