From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/dlm: call dlm_lockres_put without resource spinlock
Date: Wed, 8 Oct 2014 09:48:58 +0800 [thread overview]
Message-ID: <5434980A.2030708@huawei.com> (raw)
In-Reply-To: <20141001155549.e64a41bbf797482eb388f65b@linux-foundation.org>
On 2014/10/2 6:55, Andrew Morton wrote:
> On Fri, 26 Sep 2014 16:41:39 +0800 alex chen <alex.chen@huawei.com> wrote:
>
>> dlm_lockres_put should be called without &res->spinlock, otherwise a
>> deadlock case may happen.
>>
>> spin_lock(&res->spinlock)
>> ...
>> dlm_lockres_put
>> ->dlm_lockres_release
>> ->dlm_print_one_lock_resource
>> ->spin_lock(&res->spinlock)
>>
>> Signed-off-by: Alex Chen <alex.chen@huawei.com>
>> Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
>> ---
>> fs/ocfs2/dlm/dlmrecovery.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
>> index 45067fa..3365839 100644
>> --- a/fs/ocfs2/dlm/dlmrecovery.c
>> +++ b/fs/ocfs2/dlm/dlmrecovery.c
>> @@ -1710,9 +1710,12 @@ int dlm_master_requery_handler(struct o2net_msg *msg, u32 len, void *data,
>> BUG();
>
> This code does a GFP_ATOMIC allocation attempt and if that fails, it
> goes BUG().
>
> Guys, GFP_ATOMIC is unreliable. This isn't production quality code :(
>
Last time we talked about this and Wengang sugguested it return an
error to the sender and let the sender retry.
I'll take this idea and send a patch.
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
>
prev parent reply other threads:[~2014-10-08 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 8:41 [Ocfs2-devel] [PATCH] ocfs2/dlm: call dlm_lockres_put without resource spinlock alex chen
2014-10-01 22:55 ` Andrew Morton
2014-10-08 1:48 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5434980A.2030708@huawei.com \
--to=joseph.qi@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox