From: Srinivas Eeda <srinivas.eeda@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags
Date: Wed, 21 Jan 2015 17:12:06 -0800 [thread overview]
Message-ID: <54C04E66.4090506@oracle.com> (raw)
In-Reply-To: <54C04D64.80501@huawei.com>
Ok, understood. Thanks for explaining :)
On 01/21/2015 05:07 PM, Joseph Qi wrote:
> Hi Srini,
>
> On 2015/1/22 1:55, Srinivas Eeda wrote:
>> Hi Joesph,
>>
>> thanks a lot for submitting the above patch. I am trying to understand what kind of flag corruption have you noticed and under what circumstances ? I agree with the patch that bitwise operations are better than adding, but I am not able to understand the corruption it could cause. Can you please share!
>>
> Suppose a the following case:
> The dinode i_flag already has the OCFS2_ORPHANED_FL bit set, and calling
> le32_add_cpu again. Then it will corrupt the i_flag.
>
> --
> Joseph
>
>> Thanks,
>> --Srini
>>
>>
>>
>
prev parent reply other threads:[~2015-01-22 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54BFE80E.7090002@oracle.com>
2015-01-22 1:07 ` [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags Joseph Qi
2015-01-22 1:12 ` Srinivas Eeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C04E66.4090506@oracle.com \
--to=srinivas.eeda@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox