ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Goldwyn Rodrigues <rgoldwyn@suse.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Question about incorrect free bits setting
Date: Fri, 27 Mar 2015 11:54:31 -0500	[thread overview]
Message-ID: <55158B47.1000302@suse.com> (raw)
In-Reply-To: <5514BFFF.7070009@huawei.com>

Hi joseph,

On 03/26/2015 09:27 PM, Joseph Qi wrote:
> Hi Goldwyn,
> I found you posted a mail to discuss about incorrect free bits setting.
> https://oss.oracle.com/pipermail/ocfs2-devel/2012-January/008458.html
>
> In this topic, Sunil said it was because of the patch added to delay
> dropping of the dentry locks (commit ea455f8ab683) and suggested to fix
> the quota issue in a different way.
> Then you reverted the patches based on Honza's new way to fix the quota
> issue.
> https://oss.oracle.com/pipermail/ocfs2-devel/2014-February/009662.html
>
> I have investigated these patches and still do not know how can it
> happen.
> Could you please tell me more about the case that bits to be cleared
> twice?

I am not sure how the quota patches were related. It was a long time ago.

However, what we fixed in Honza's patches is the way unlink is 
performed. The problem was we were getting very bad performance because 
of too much of journal activity. We realized that it was because the 
inodes were shown as busy and hence moved orphan directory, when they 
were not busy. It all came to the point that the open lock was still 
being held because it was delayed/offloaded to another thread.

I am not sure, but I guess that this delay may be messing up the 
accounting between the node being the owner of the lock and the one 
deleting the file (also requesting for the lock). I have not seen this 
issue for a long time now so I am not sure. Perhaps Sunil may be able to 
give more inputs.

-- 
Goldwyn

  reply	other threads:[~2015-03-27 16:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27  2:27 [Ocfs2-devel] Question about incorrect free bits setting Joseph Qi
2015-03-27 16:54 ` Goldwyn Rodrigues [this message]
2015-03-27 16:57   ` Goldwyn Rodrigues
2015-04-01  8:16     ` Joseph Qi
  -- strict thread matches above, loose matches on Subject: below --
2012-01-18 18:00 Goldwyn Rodrigues
2012-01-18 18:21 ` Sunil Mushran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55158B47.1000302@suse.com \
    --to=rgoldwyn@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).