From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Question about commit cf1b5ea1c5cd
Date: Tue, 14 Apr 2015 11:06:40 +0800 [thread overview]
Message-ID: <552C8440.2000106@huawei.com> (raw)
Hi Viro,
I have questions about your commit cf1b5ea1c5cd
("[regression] ocfs2: do *not* increment ->ki_pos twice").
Yes, ->ki_pos is increased in generic_file_direct_write(). But
*ppos doesn't. So I increase it here for further use in
generic_perform_write.
After this, ->ki_pos and *ppos are equal. Then after buffer write, I
only get written_buffered increased into ->ki_pos, so ->ki_pos is *not*
increased twice.
next reply other threads:[~2015-04-14 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 3:06 Joseph Qi [this message]
2015-04-14 3:40 ` [Ocfs2-devel] Question about commit cf1b5ea1c5cd Al Viro
2015-04-14 3:52 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552C8440.2000106@huawei.com \
--to=joseph.qi@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox