Linux ocfs2 filesystem development
 help / color / mirror / Atom feed
From: Junxiao Bi <junxiao.bi@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits
Date: Thu, 16 Apr 2015 13:42:17 +0800	[thread overview]
Message-ID: <552F4BB9.9090400@oracle.com> (raw)
In-Reply-To: <1428705866-26954-1-git-send-email-tariq.x.saeed@oracle.com>

Hi Tariq,

This have been fixed by upstream commit
023d4ea358494ccfeb37abfe5b0fd01b45a6051c ("ocfs2: fix possible
uninitialized variable access").

Thanks,
Junxiao.
On 04/11/2015 06:44 AM, Tariq Saeed wrote:
> Orabug: 19060842
> 
> In ocfs2_local_alloc_find_clear_bits(), local int numbits is used
> without being initialized in an error path.
> 
> Signed-off-by: Tariq Saeed <tariq.x.saeed@oracle.com>
> ---
>  fs/ocfs2/localalloc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
> index 0440134..978a6e0 100644
> --- a/fs/ocfs2/localalloc.c
> +++ b/fs/ocfs2/localalloc.c
> @@ -847,6 +847,7 @@ static int ocfs2_local_alloc_find_clear_bits(struct ocfs2_super *osb,
>  
>  	if (!alloc->id1.bitmap1.i_total) {
>  		bitoff = -1;
> +		numfound = -1;
>  		goto bail;
>  	}
>  
> 

      reply	other threads:[~2015-04-16  5:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 22:44 [Ocfs2-devel] [PATCH 1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits Tariq Saeed
2015-04-16  5:42 ` Junxiao Bi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552F4BB9.9090400@oracle.com \
    --to=junxiao.bi@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox