From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2 v2] ocfs2: fix race between dio and recover orphan
Date: Mon, 13 Jul 2015 08:54:28 +0800 [thread overview]
Message-ID: <55A30C44.3090006@huawei.com> (raw)
In-Reply-To: <55A2C9A6020000D40006F887@relay2.provo.novell.com>
On 2015/7/12 18:10, Zhen Ren wrote:
> Hi Joseph,
>
> The following added lines are same as the deleted. Is it because the unnecessary trailing whitespaces?
>
> - level = ocfs2_iocb_rw_locked_level(iocb);
> - ocfs2_rw_unlock(inode, level);
> + level = ocfs2_iocb_rw_locked_level(iocb);
> + ocfs2_rw_unlock(inode, level);
>
No, I want rw unlock to be done later in case of append direct io. This
is for preventing the described race case.
> --
> Eric
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
>
>
>
prev parent reply other threads:[~2015-07-13 0:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 11:18 [Ocfs2-devel] [PATCH 1/2 v2] ocfs2: fix race between dio and recover orphan Joseph Qi
2015-07-12 10:10 ` Zhen Ren
2015-07-13 0:54 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A30C44.3090006@huawei.com \
--to=joseph.qi@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox