Linux ocfs2 filesystem development
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [RFC] Doubt about dlm_worker
Date: Sun, 6 Sep 2015 21:11:53 +0800	[thread overview]
Message-ID: <55EC3B99.7040601@huawei.com> (raw)

Comments for dlm_dispatch_work is described below:
/* Worker function used during recovery. */

But actually dlm_worker is used by 4 types of dlm message workers:
	dlm_assert_master_worker
	dlm_deref_lockres_worker
	dlm_request_all_locks_worker
	dlm_mig_lockres_worker

And the first 2 are not dlm recovery related. Moreover, it will send
DLM_ASSERT_MASTER_MSG to all other nodes in dlm_assert_master_worker.
And it may do a lot of assert master during recovery. In our scenario,
it is tens of thousands.
This will delay the recovery because dlm_worker is a single thread
workqueue and cluster is hanging during dlm recovery.
So I doubt if we can move the assert master to a new workqueue or just
use a system workqueue.
Any suggestions?

             reply	other threads:[~2015-09-06 13:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-06 13:11 Joseph Qi [this message]
2015-09-10 11:49 ` [Ocfs2-devel] [RFC] Doubt about dlm_worker Joseph Qi
2015-09-10 19:18   ` Sunil Mushran
2015-09-11  2:19   ` Junxiao Bi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EC3B99.7040601@huawei.com \
    --to=joseph.qi@huawei.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox